Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to a V3 only SDK #526

Merged
merged 21 commits into from
Nov 12, 2024
Merged

Update to a V3 only SDK #526

merged 21 commits into from
Nov 12, 2024

Conversation

nplasterer
Copy link
Contributor

Remove V1 & V2 Conversation interfaces
Remove unneeded decrypt method
Remove contacts and replace with private preferences
Remove V2 client and associated classes
Big Overhaul of the tests

@nplasterer nplasterer self-assigned this Nov 8, 2024
@nplasterer
Copy link
Contributor Author

nplasterer commented Nov 12, 2024

All the tests are green! 🎉

Android iOS
Screenshot 2024-11-11 at 8 37 11 PM Screenshot 2024-11-11 at 8 51 05 PM

Some follow ups that would be nice:

  • Polish up the example app
  • Updating the send messages to mirror how v2 convos handled it
  • Take pass on performance + tests
  • Frames client
  • Any additional polish

this version bump removes all v2 functionality

BREAKING CHANGE: This commit removes all v2 functionality creating a pure v3 experience.
@nplasterer nplasterer marked this pull request as ready for review November 12, 2024 05:19
@nplasterer nplasterer requested a review from a team as a code owner November 12, 2024 05:19
Copy link

@codabrink codabrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks really good, nice work!

@nplasterer nplasterer merged commit 3d76bf1 into main Nov 12, 2024
5 of 6 checks passed
@nplasterer nplasterer deleted the np/v3 branch November 12, 2024 15:51
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants